Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reword jsx-no-bind rationale #3581

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Reword jsx-no-bind rationale #3581

merged 1 commit into from
Jun 8, 2023

Conversation

gpoole
Copy link
Contributor

@gpoole gpoole commented May 30, 2023

I'm proposing rewording the rationale for jsx-no-bind to:

  • clarify that the performance concerns apply to specific situations; although it's qualified, the statement "is bad for performance" is a general statement and not strictly accurate
  • refer explicitly to memo since I think memoised components are probably the most common component with performance impacts from this rule
  • include the fact that this rule also covers any function declared in the render method of a component, including both anonymous or named functions, not just arrow or bound functions, as shown in the examples

@gpoole @ljharb
[Docs] jsx-no-bind: reword performance rationale
ae64aa8 
Rewording the performance rationale for jsx-no-bind to clarify that the performance implications are specifically for memoized components.
@codecov
Copy link

codecov bot commented May 30, 2023 •
edited
Loading

Codecov Report

Merging #3581 (2b2a9bb) into master (7f655f8) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 2b2a9bb differs from pull request most recent head ae64aa8. Consider uploading reports for the commit ae64aa8 to get more accurate results

@@           Coverage Diff           @@
##           master    #3581   +/-   ##
=======================================
  Coverage   97.61%   97.62%           
=======================================
  Files         132      132           
  Lines        9280     9295   +15     
  Branches     3391     3400    +9     
=======================================
+ Hits         9059     9074   +15     
  Misses        221      221

see 1 file with indirect coverage changes

ljharb
ljharb requested changes May 30, 2023
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on this?

Also, could we maybe add some examples as well to showcase the different kinds of functions that apply?

docs/rules/jsx-no-bind.md Outdated Show resolved Hide resolved
@gpoole
Copy link
Contributor Author

gpoole commented May 31, 2023

I've also now updated the "when not to use section" to be consistent with the rationale. Sorry for the multiple micro edits!

@ljharb ljharb merged commit ae64aa8 into jsx-eslint:master Jun 8, 2023
@iamjohnnym iamjohnnym mentioned this pull request Mar 20, 2024
Closed
1 task
@BuloZB BuloZB mentioned this pull request May 19, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request May 24, 2024
Open
@Balantion2020 Balantion2020 mentioned this pull request May 24, 2024
Open
This was referenced May 24, 2024
Open
Open
Open
@mjperrins mjperrins mentioned this pull request May 30, 2024
Open
@richyhoopd richyhoopd mentioned this pull request Jun 3, 2024
Open
@Luis-Kristen Luis-Kristen mentioned this pull request Jun 3, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request Jun 3, 2024
Open
@Balantion2020 Balantion2020 mentioned this pull request Jun 3, 2024
Open
This was referenced Jun 3, 2024
Open
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Jun 4, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Jun 5, 2024
Open
@paaschdigital paaschdigital mentioned this pull request Jun 7, 2024
Open
@MANAALHARBI MANAALHARBI mentioned this pull request Jun 8, 2024
Merged
@richyhoopd richyhoopd mentioned this pull request Jun 18, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Jun 18, 2024
Open
This was referenced Jun 18, 2024
Open
Open
@Exkaleburx Exkaleburx mentioned this pull request Aug 10, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Aug 10, 2024
Open
@Luis-Kristen Luis-Kristen mentioned this pull request Aug 11, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Aug 11, 2024
Open
@richyhoopd richyhoopd mentioned this pull request Aug 11, 2024
Open
@ASISBusiness ASISBusiness mentioned this pull request Aug 16, 2024
Closed
@Exkaleburx Exkaleburx mentioned this pull request Aug 20, 2024
Open
@Jcrandall541 Jcrandall541 mentioned this pull request Aug 21, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request Aug 22, 2024
Open
@richyhoopd richyhoopd mentioned this pull request Aug 22, 2024
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Aug 22, 2024
Open
@Balantion2020 Balantion2020 mentioned this pull request Aug 22, 2024
Open
This was referenced Aug 22, 2024
Open
Open
Open
@Luis-Kristen Luis-Kristen mentioned this pull request Aug 24, 2024
Open
@Herychukwu Herychukwu mentioned this pull request Aug 31, 2024
Open
@AKJUS AKJUS mentioned this pull request Sep 12, 2024
Open
@sanisoclem sanisoclem mentioned this pull request Sep 15, 2024
Open
@scatools-demo scatools-demo mentioned this pull request Sep 23, 2024
Open
@Luis-Kristen Luis-Kristen mentioned this pull request Sep 24, 2024
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Sep 24, 2024
Open
This was referenced Sep 24, 2024
Open
Open
@Balantion2020 Balantion2020 mentioned this pull request Sep 24, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Sep 24, 2024
Open
This was referenced Sep 24, 2024
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
documentation
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gpoole @ljharb